[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xg
From: |
Bruno Haible |
Subject: |
Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd |
Date: |
Thu, 18 Nov 2004 14:12:11 +0100 |
User-agent: |
KMail/1.5 |
Paul Eggert wrote:
> * lib/xgetcwd.c: Include <limits.h>, for PATH_MAX.
> (xgetcwd): Set errno correctly when failing.
> Work around Solaris 9 bug: getcwd sets errno==ERANGE even though
> the failure is actually due to a PATH_MAX problem.
This patch defeats the purpose of the module, which is "return current
directory with unlimited length". Some platforms have a PATH_MAX value that
is not a strong limit, but rather a dummy value because many BSD applications
don't even compile if PATH_MAX does not exist.
Can you limit the workaround to the platforms that need it, i.e. replace
"#ifdef PATH_MAX" with "#ifdef __sun" (or use an autoconf test)?
Bruno
- [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Paul Eggert, 2004/11/17
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd,
Bruno Haible <=
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Paul Eggert, 2004/11/18
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Bruno Haible, 2004/11/18
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Jim Meyering, 2004/11/18
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Paul Eggert, 2004/11/19
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Jim Meyering, 2004/11/19
- Re: [Bug-gnulib] gnulib imports from coreutils for canon-host, human, xgetcwd, Paul Eggert, 2004/11/19