[bug-gnulib] Re: getdate don't need alloca

[Simon Josefsson]

Bruno Haible <address@hidden> writes:

> Simon Josefsson wrote:
>> Would wrapping the #include inside a #if HAVE_ALLOCA test work?
>
> Probably yes. But gnulib is generally going into the opposite direction:
> Move the #ifs from the .c file that uses the header into the header itself,
> in this case by use of a substitute for alloca.h.

Ok.

So could getdate depend on alloca-opt instead of alloca?

Or is alloca.h required for bison 1.30 generated output to compile?  I
looked at output from bison 1.35, and it seemed to only optionally use
alloca, when YYSTACK_USE_ALLOCA was defined.  Presumably the user
would have to define YYSTACK_USE_ALLOCA elsewhere, such as in CFLAGS
or in config.h.  getdate.y doesn't set it, as far as I can tell.  The
code seemed to fall back on malloc+free if YYSTACK_USE_ALLOCA was not
enabled.

So it seems to me that using alloca-opt would have no bad effects

Maybe 1.30 was different, though...

Thanks.