[bug-gnulib] Re: [PATCH] mmap-anon.m4: use proper macro & condition

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Moriyoshi Koizumi <address@hidden> writes:

> Hmm, seems the attachments were stripped. I placed them on
> 
> http://www.voltex.jp/patches/cvs-1.12.12-mmap-anon-20050424.patch.diff.gz
> http://www.voltex.jp/patches/cvs-1.12.12-pam-header-20050424-patch.diff.gz
> 
> Regards,
> Moriyoshi
> 
> On 2005/04/24, at 8:04, Moriyoshi Koizumi wrote:
> 
> > Hello,
> >
> > Attached is a patch against 1.12.12 that fixes the MMAP_ANON
> > detection problem in mmap-anon.m4 that would lead to unexpected
> > "memory exhausted" error on several platforms.

Examples of such platforms would be nice to include for the ChangeLog...

> >
> > Hope this helps anyway.
> >
> > Regards,
> > Moriyoshi

A patch to m4/mmap-anon.m4 would need to be made to the GNULIB master
sources. I am CC'ing address@hidden on this message.

The patch to look for at using a #include <pam/pam_appl.h> for MacOS X
seems reasonable. I'll try to dig up a MacOS X box to as a test before I
commit it. For the ChangeLog entry, do you happen to know for which
MacOS X releases this support (10.0, 10.1, 10.2, 10.3, ...) applies?

        Thanks,
        -- Mark

 --- cvs-1.12.12.orig/m4/mmap-anon.m4   Tue Mar  8 03:22:03 2005
 +++ cvs-1.12.12/m4/mmap-anon.m4        Sun Apr 24 07:50:24 2005
 @@ -27,8 +27,8 @@
  #endif
  ],
        [gl_have_mmap_anonymous=yes])
 -    if test $gl_have_mmap_anonymous = no; then
 -      AC_EGREP_HEADER([MAP_ANON], [
 +    if test $gl_have_mmap_anonymous != yes; then
 +      AC_EGREP_CPP([I cant identify this map.], [
  #include <sys/mman.h>
  #ifdef MAP_ANON
      I cant identify this map.
 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFCaybd3x41pRYZE/gRAh5WAJ9BBMZWKREjPIFdgbT8L6oLSKz5ewCdG8hx
PRqB3KOJvluQ7Y6+nMUcHDI=
=a2+C
-----END PGP SIGNATURE-----