Re: [bug-gnulib] dirname module should depend on stdbool

[Paul Eggert]

Dave Love <address@hidden> writes:

> dirname.h includes stdbool.h but the dirname module is missing a
> Depends-on for it.

I omitted stdbool on the theory that packages that to assume C99 don't
need to use the stdbool module, since stdbool.h comes with C99.

However, this subject seems to recover, so (to save everyone some
time) I've added that dependency as follows.  In the long run stdbool
will go away, since C99 will become universal, but that will be
several years from now I guess.

2005-05-06  Paul Eggert  <address@hidden>

        * modules/argmatch (Depends-on): Add stdbool.
        * modules/backupfile (Depends-on): Likewise.
        * modules/chdir-long (Depends-on): Likewise.
        * modules/closeout (Depends-on): Likewise.
        * modules/cycle-check (Depends-on): Likewise.
        * modules/dirname (Depends-on): Likewise.
        * modules/fnmatch (Depends-on): Likewise.
        * modules/fsusage (Depends-on): Likewise.
        * modules/fwriteerror (Depends-on): Likewise.
        * modules/getcwd (Depends-on): Likewise.
        * modules/getloadavg (Depends-on): Likewise.
        * modules/hard-locale (Depends-on): Likewise.
        * modules/makepath (Depends-on): Likewise.
        * modules/mountlist (Depends-on): Likewise.
        * modules/nanosleep (Depends-on): Likewise.
        * modules/posixtm (Depends-on): Likewise.
        * modules/quotearg (Depends-on): Likewise.
        * modules/readtokens (Depends-on): Likewise.
        * modules/readtokens0 (Depends-on): Likewise.
        * modules/readutmp (Depends-on): Likewise.
        * modules/save-cwd (Depends-on): Likewise.
        * modules/strftime (Depends-on): Likewise.
        * modules/userspec (Depends-on): Likewise.
        * modules/utimecmp (Depends-on): Likewise.
        * modules/xgetcwd (Depends-on): Likewise.
        * modules/xnanosleep (Depends-on): Likewise.
        * modules/xstrtod (Depends-on): Likewise.
        * modules/yesno (Depends-on): Likewise.

Index: modules/argmatch
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/argmatch,v
retrieving revision 1.8
diff -p -u -r1.8 argmatch
--- modules/argmatch    4 Oct 2004 20:17:39 -0000       1.8
+++ modules/argmatch    6 May 2005 17:20:30 -0000
@@ -12,6 +12,7 @@ quotearg
 quote
 exit
 exitfail
+stdbool
 
 configure.ac:
 
@@ -26,4 +27,3 @@ GPL
 
 Maintainer:
 all
-
Index: modules/backupfile
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/backupfile,v
retrieving revision 1.6
diff -p -u -r1.6 backupfile
--- modules/backupfile  21 Mar 2005 22:07:25 -0000      1.6
+++ modules/backupfile  6 May 2005 17:20:30 -0000
@@ -12,6 +12,7 @@ m4/backupfile.m4
 Depends-on:
 argmatch
 dirname
+stdbool
 
 configure.ac:
 gl_BACKUPFILE
Index: modules/chdir-long
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/chdir-long,v
retrieving revision 1.4
diff -p -u -r1.4 chdir-long
--- modules/chdir-long  21 Mar 2005 20:50:10 -0000      1.4
+++ modules/chdir-long  6 May 2005 17:20:30 -0000
@@ -10,6 +10,7 @@ Depends-on:
 openat
 mempcpy
 memrchr
+stdbool
 
 configure.ac:
 gl_FUNC_CHDIR_LONG
Index: modules/closeout
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/closeout,v
retrieving revision 1.10
diff -p -u -r1.10 closeout
--- modules/closeout    21 Mar 2005 22:07:25 -0000      1.10
+++ modules/closeout    6 May 2005 17:20:30 -0000
@@ -13,6 +13,7 @@ error
 quotearg
 fpending
 exitfail
+stdbool
 
 configure.ac:
 gl_CLOSEOUT
Index: modules/cycle-check
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/cycle-check,v
retrieving revision 1.2
diff -p -u -r1.2 cycle-check
--- modules/cycle-check 22 Sep 2004 15:11:04 -0000      1.2
+++ modules/cycle-check 6 May 2005 17:20:30 -0000
@@ -7,6 +7,7 @@ lib/cycle-check.h
 lib/dev-ino.h
 
 Depends-on:
+stdbool
 
 configure.ac:
 
@@ -21,4 +22,3 @@ GPL
 
 Maintainer:
 Jim Meyering
-
Index: modules/dirname
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/dirname,v
retrieving revision 1.5
diff -p -u -r1.5 dirname
--- modules/dirname     21 Mar 2005 22:07:25 -0000      1.5
+++ modules/dirname     6 May 2005 17:20:30 -0000
@@ -11,6 +11,7 @@ m4/dirname.m4
 
 Depends-on:
 xalloc
+stdbool
 
 configure.ac:
 gl_DIRNAME
Index: modules/fnmatch
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/fnmatch,v
retrieving revision 1.7
diff -p -u -r1.7 fnmatch
--- modules/fnmatch     22 Sep 2004 15:11:04 -0000      1.7
+++ modules/fnmatch     6 May 2005 17:20:30 -0000
@@ -10,6 +10,7 @@ m4/fnmatch.m4
 
 Depends-on:
 alloca
+stdbool
 
 configure.ac:
 # No macro. You should also use one of fnmatch-posix or fnmatch-gnu.
Index: modules/fsusage
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/fsusage,v
retrieving revision 1.5
diff -p -u -r1.5 fsusage
--- modules/fsusage     21 Mar 2005 22:07:25 -0000      1.5
+++ modules/fsusage     6 May 2005 17:20:30 -0000
@@ -12,6 +12,7 @@ m4/fsusage.m4
 
 Depends-on:
 full-read
+stdbool
 
 configure.ac:
 gl_FSUSAGE
Index: modules/fwriteerror
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/fwriteerror,v
retrieving revision 1.2
diff -p -u -r1.2 fwriteerror
--- modules/fwriteerror 22 Sep 2004 15:11:04 -0000      1.2
+++ modules/fwriteerror 6 May 2005 17:20:30 -0000
@@ -6,6 +6,7 @@ lib/fwriteerror.h
 lib/fwriteerror.c
 
 Depends-on:
+stdbool
 
 configure.ac:
 
Index: modules/getcwd
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getcwd,v
retrieving revision 1.6
diff -p -u -r1.6 getcwd
--- modules/getcwd      2 May 2005 05:29:35 -0000       1.6
+++ modules/getcwd      6 May 2005 17:20:30 -0000
@@ -11,6 +11,7 @@ m4/getcwd.m4
 Depends-on:
 mempcpy
 extensions
+stdbool
 
 configure.ac:
 gl_FUNC_GETCWD
Index: modules/getloadavg
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getloadavg,v
retrieving revision 1.8
diff -p -u -r1.8 getloadavg
--- modules/getloadavg  2 May 2005 07:00:50 -0000       1.8
+++ modules/getloadavg  6 May 2005 17:20:30 -0000
@@ -9,6 +9,7 @@ Depends-on:
 cloexec
 xalloc
 c-strtod
+stdbool
 unistd-safer
 
 configure.ac:
Index: modules/hard-locale
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/hard-locale,v
retrieving revision 1.6
diff -p -u -r1.6 hard-locale
--- modules/hard-locale 21 Mar 2005 22:07:25 -0000      1.6
+++ modules/hard-locale 6 May 2005 17:20:30 -0000
@@ -7,6 +7,7 @@ lib/hard-locale.c
 m4/hard-locale.m4
 
 Depends-on:
+stdbool
 strdup
 
 configure.ac:
Index: modules/makepath
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/makepath,v
retrieving revision 1.7
diff -p -u -r1.7 makepath
--- modules/makepath    22 Mar 2005 07:44:16 -0000      1.7
+++ modules/makepath    6 May 2005 17:20:30 -0000
@@ -16,6 +16,7 @@ dirname
 error
 quote
 stat-macros
+stdbool
 
 configure.ac:
 gl_MAKEPATH
Index: modules/mountlist
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/mountlist,v
retrieving revision 1.6
diff -p -u -r1.6 mountlist
--- modules/mountlist   21 Mar 2005 22:07:25 -0000      1.6
+++ modules/mountlist   6 May 2005 17:20:30 -0000
@@ -9,6 +9,7 @@ m4/fstypename.m4
 m4/mountlist.m4
 
 Depends-on:
+stdbool
 xalloc
 
 configure.ac:
Index: modules/nanosleep
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/nanosleep,v
retrieving revision 1.5
diff -p -u -r1.5 nanosleep
--- modules/nanosleep   22 Sep 2004 15:11:04 -0000      1.5
+++ modules/nanosleep   6 May 2005 17:20:30 -0000
@@ -7,6 +7,7 @@ m4/nanosleep.m4
 
 Depends-on:
 timespec
+stdbool
 
 configure.ac:
 gl_FUNC_NANOSLEEP
@@ -21,4 +22,3 @@ GPL
 
 Maintainer:
 Jim Meyering
-
Index: modules/posixtm
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/posixtm,v
retrieving revision 1.7
diff -p -u -r1.7 posixtm
--- modules/posixtm     21 Mar 2005 22:07:25 -0000      1.7
+++ modules/posixtm     6 May 2005 17:20:30 -0000
@@ -8,6 +8,7 @@ m4/posixtm.m4
 
 Depends-on:
 mktime
+stdbool
 
 configure.ac:
 gl_POSIXTM
Index: modules/quotearg
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/quotearg,v
retrieving revision 1.5
diff -p -u -r1.5 quotearg
--- modules/quotearg    21 Mar 2005 22:07:25 -0000      1.5
+++ modules/quotearg    6 May 2005 17:20:30 -0000
@@ -11,6 +11,7 @@ m4/quotearg.m4
 Depends-on:
 xalloc
 gettext
+stdbool
 
 configure.ac:
 gl_QUOTEARG
Index: modules/readtokens
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/readtokens,v
retrieving revision 1.6
diff -p -u -r1.6 readtokens
--- modules/readtokens  21 Mar 2005 22:07:25 -0000      1.6
+++ modules/readtokens  6 May 2005 17:20:30 -0000
@@ -8,6 +8,7 @@ m4/readtokens.m4
 
 Depends-on:
 xalloc
+stdbool
 
 configure.ac:
 gl_READTOKENS
Index: modules/readtokens0
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/readtokens0,v
retrieving revision 1.2
diff -p -u -r1.2 readtokens0
--- modules/readtokens0 22 Sep 2004 15:11:04 -0000      1.2
+++ modules/readtokens0 6 May 2005 17:20:30 -0000
@@ -7,6 +7,7 @@ lib/readtokens0.c
 
 Depends-on:
 obstack
+stdbool
 
 configure.ac:
 
@@ -21,4 +22,3 @@ GPL
 
 Maintainer:
 Jim Meyering
-
Index: modules/readutmp
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/readutmp,v
retrieving revision 1.6
diff -p -u -r1.6 readutmp
--- modules/readutmp    21 Mar 2005 22:07:25 -0000      1.6
+++ modules/readutmp    6 May 2005 17:20:30 -0000
@@ -8,6 +8,7 @@ m4/readutmp.m4
 
 Depends-on:
 xalloc
+stdbool
 
 configure.ac:
 gl_READUTMP
Index: modules/save-cwd
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/save-cwd,v
retrieving revision 1.8
diff -p -u -r1.8 save-cwd
--- modules/save-cwd    2 May 2005 07:00:50 -0000       1.8
+++ modules/save-cwd    6 May 2005 17:20:30 -0000
@@ -10,6 +10,7 @@ Depends-on:
 chdir-long
 unistd-safer
 xgetcwd
+stdbool
 
 configure.ac:
 gl_SAVE_CWD
Index: modules/strftime
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/strftime,v
retrieving revision 1.12
diff -p -u -r1.12 strftime
--- modules/strftime    21 Mar 2005 22:07:25 -0000      1.12
+++ modules/strftime    6 May 2005 17:20:30 -0000
@@ -11,6 +11,7 @@ m4/strftime.m4
 Depends-on:
 time_r
 tzset
+stdbool
 
 configure.ac:
 gl_FUNC_GNU_STRFTIME
Index: modules/userspec
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/userspec,v
retrieving revision 1.11
diff -p -u -r1.11 userspec
--- modules/userspec    23 Mar 2005 11:51:18 -0000      1.11
+++ modules/userspec    6 May 2005 17:20:30 -0000
@@ -14,6 +14,7 @@ xalloc
 xstrtol
 strdup
 gettext
+stdbool
 
 configure.ac:
 gl_USERSPEC
Index: modules/utimecmp
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/utimecmp,v
retrieving revision 1.4
diff -p -u -r1.4 utimecmp
--- modules/utimecmp    21 Mar 2005 22:07:25 -0000      1.4
+++ modules/utimecmp    6 May 2005 17:20:30 -0000
@@ -12,6 +12,7 @@ hash
 timespec
 utimens
 xalloc
+stdbool
 
 configure.ac:
 gl_UTIMECMP
Index: modules/xgetcwd
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/xgetcwd,v
retrieving revision 1.5
diff -p -u -r1.5 xgetcwd
--- modules/xgetcwd     26 Nov 2004 08:35:30 -0000      1.5
+++ modules/xgetcwd     6 May 2005 17:20:30 -0000
@@ -9,6 +9,7 @@ m4/xgetcwd.m4
 Depends-on:
 getcwd
 xalloc
+stdbool
 
 configure.ac:
 gl_XGETCWD
Index: modules/xnanosleep
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/xnanosleep,v
retrieving revision 1.5
diff -p -u -r1.5 xnanosleep
--- modules/xnanosleep  9 Mar 2005 19:11:23 -0000       1.5
+++ modules/xnanosleep  6 May 2005 17:20:30 -0000
@@ -9,6 +9,7 @@ m4/xnanosleep.m4
 
 Depends-on:
 timespec
+stdbool
 
 configure.ac:
 gl_XNANOSLEEP
Index: modules/xstrtod
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/xstrtod,v
retrieving revision 1.4
diff -p -u -r1.4 xstrtod
--- modules/xstrtod     22 Sep 2004 15:11:04 -0000      1.4
+++ modules/xstrtod     6 May 2005 17:20:30 -0000
@@ -7,6 +7,7 @@ lib/xstrtod.c
 m4/xstrtod.m4
 
 Depends-on:
+stdbool
 
 configure.ac:
 gl_XSTRTOD
@@ -22,4 +23,3 @@ GPL
 
 Maintainer:
 Jim Meyering
-
Index: modules/yesno
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/yesno,v
retrieving revision 1.8
diff -p -u -r1.8 yesno
--- modules/yesno       21 Mar 2005 22:07:25 -0000      1.8
+++ modules/yesno       6 May 2005 17:20:30 -0000
@@ -9,6 +9,7 @@ m4/yesno.m4
 
 Depends-on:
 rpmatch
+stdbool
 
 configure.ac:
 gl_YESNO