Re: [bug-gnulib] [bug-gnulib] [PATCH]: inet_ntop module for GnuLib

[Bruno Haible]

Yoann Vandoorselaere wrote:
> Attached is a patch adding an inet_ntop module to GnuLib. The code has
> been adapted from the inet_ntop glibc code.

Thanks. I've added this module with minor tweaks:
  - modules/inet_ntop: Add a description.
  - modules/inet_ntop: Add 'glibc' to maintainers, so that we are reminded
    that changes should be synchronized with glibc.
  - m4/inet_ntop.m4: Use new copyright recommended by RMS.
  - m4/inet_ntop.m4: Remove unused AC_C_INLINE.
  - lib/inet_ntop.h: Add a copyright notice.
  - lib/inet_ntop.h: Add comments.
  - lib/inet_ntop.h: Simplify #if condition.
  - lib/inet_ntop.c: Include the header file first.
  - lib/inet_ntop.c: Verify that sizeof(int) >= 4.
  - lib/inet_ntop.c: Enclose the functions in #ifdef as well, since it doesn't
    make sense to compile inet_ntop6() if it's not used.

The following have not been addressed:
  - Not all systems have <arpa/inet.h>.

Bruno