Re: strfile: new module

[Simon Josefsson]

Ralf Wildenhues <address@hidden> writes:

> * Ralf Wildenhues wrote on Sat, May 27, 2006 at 12:22:35PM CEST:
>> * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST:
>> > +  int save_errno = errno;
>> 
>> You are using errno but not including <errno.h>.
>
> ...and realloc but not including <stdlib.h>.
> Please compile your code with lots of warnings enabled.

Fixed in last e-mail too.

> You pass NULL to realloc and possibly to free but are not
> depending on the realloc and free modules.

The free case was fixed in the last e-mail, but isn't realloc supposed
to handle NULL?

> I wonder whether you want to read it in text or in binary
> mode (for Cygwin...).

Both GnuTLS and Shishi wants it in binary mode...  I've fixed this in
my local copy.

Thanks,
Simon