Re: proposed gnulib module 'configmake', plus use by 'localcharset'

[Ralf Wildenhues]

Hello Paul,

* Paul Eggert wrote on Fri, Aug 25, 2006 at 09:34:21AM CEST:
> 
> I propose that we add a module that creates a file 'configmake.h'
> defining symbols like LIBDIR (or better, to avoid name space
> collisions, CONFIGMAKE_LIBDIR).  configmake.h would contain the make
> directory variables required by the GNU coding standards.

I like the idea.  It could be added to `(autoconf.info)Defining
Directories'.

> +# Listed in the same order as the GNU makefile conventions.
> +configmake.h:

configmake.h should depend on $(top_builddir)/config.status, I think.

> --- modules/localcharset      22 Sep 2004 15:11:04 -0000      1.6
> +++ modules/localcharset      25 Aug 2006 06:41:39 -0000
> @@ -12,6 +12,7 @@ m4/glibc21.m4
>  m4/localcharset.m4
>  
>  Depends-on:
> +configmake
>  
>  configure.ac:
>  gl_LOCALCHARSET
> @@ -19,7 +20,8 @@ gl_LOCALCHARSET
>  Makefile.am:
>  lib_SOURCES += localcharset.h localcharset.c
>  EXTRA_DIST += config.charset ref-add.sin ref-del.sin
> -DEFS += -DLIBDIR=\"$(libdir)\"
> +
> +localcharset.$(OBJEXT): configmake.h

I'd either add a dependency to localcharset.lo as well, or, preferably
replace the above with
  BUILT_SOURCES += configmake.h

Cheers,
Ralf