Re: getcwd infinite recursion

[Colin Watson]

On Sun, Oct 14, 2007 at 11:07:28PM +0200, Bruno Haible wrote:
> Colin Watson wrote:
> > I made this change and it now works correctly.
> 
> Thanks for checking. That's important to know.
> 
> How exactly did you invoke gnulib-tool? With or without a --makefile-name
> option?

Without. Also, I'm installing Gnulib's files into gnulib/lib/ and
gnulib/m4/, since I already had lib/ and m4/ directories and there were
clashes.

> > Gnulib needs to put -I. in its AM_CPPFLAGS, since it
> > appears to define that variable to empty
> 
> Yes, I agree that this may be the mistake.
> 
> > thus cancelling Automake's default behaviour.
> 
> To me, it looks like AM_CPPFLAGS is empty by default. Automake's default
> includes are in a separate variable called DEFAULT_INCLUDES.

Yes, you seem to be right:

  $ egrep 'AM_CPPFLAGS|DEFAULT_INCLUDES' gnulib/lib/Makefile
  DEFAULT_INCLUDES = -I. -I$(top_builddir)
  COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
  AM_CPPFLAGS =


I was trying to prepare a test case for you, but I find that now I
cannot reproduce the problem, either with VPATH or non-VPATH builds! It
seems there must have been some junk lying around in my tree after all,
so I must apologise sincerely for bothering you all. Something like
Bruno's guard patches would still be useful, as it would have alerted me
to the problem at compile-time rather than building cleanly only to
crash at run-time.

In case it's interesting to somebody anyway, I've put a tarball of my
current tree at the following URL temporarily. I'm aware that it is not
yet using Gnulib entirely correctly; in particular I still need to set
AC_CONFIG_LIBOBJ_DIR and do something with the few remaining LIBOBJ
candidates I need to provide.

  http://people.debian.org/~cjwatson/tmp/man-db-gnulib.tar.gz

Thanks,

-- 
Colin Watson                                       address@hidden