Re: new module: xprintf

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> Thanks; this module is necessary.
>
> Two suggestions:
>
> - Add a call to va_end() that matches the va_start() call. POSIX says:
>   "Each invocation of the va_start() and va_copy() macros shall be matched
>    by a corresponding invocation of the va_end() macro in the same function."
>
> - I would make it clearer in the error message that the error is about
>   formatted output. I don't feel that "write error" is good enough, given
>   that the usual reasons for failing printf(), when !ferror(stream), are:
>     EINVAL - invalid format string
>     EILSEQ - cannot convert a wide character string
>     ENOMEM - out of memory
>   and these are not immediately related to writing on the stream.

Thanks.
I applied your patch.