[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Remove useless "if" tests before free. Deprecate "free" modu
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] Remove useless "if" tests before free. Deprecate "free" module. |
Date: |
Sun, 02 Mar 2008 17:14:13 +0100 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> Here's a proposed patch to remove all redundant "if"-before-free
> tests in the tests/ directory and in the lib/*.c files not owned
> by Bruno. It also deprecates (in comments and documentation) the
> free module. Paul ok'd that part.
>
> Simon, this affects two files that are yours: lib/gc-gnulib.c and
> lib/getaddrinfo.c. Please let me know if this is ok with you.
> If not, I'll be happy to remove them from the list.
It's fine by me. I recall having some reason for adding such checks
(not necessarily in this code) on some platforms, but maybe there are
obsolete by now. Anyway, users will definitely report it if there still
are any platforms with problems in that area.
/Simon