paying for the sin of no unit tests: useless-if-before-free bug

[Jim Meyering]

I noticed that I'd broken my useless-if-before-free script.
It would only notice the useless tests if there were
a cast on the argument to the free-like function.

I've just pushed this correction and will add unit tests.

>From e47886762b67882c67f9b76f41a1f89c3552c4aa Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 29 Apr 2008 20:02:22 +0200
Subject: [PATCH] Fix broken useless-if-before-free script.

* build-aux/useless-if-before-free: Fix typo: missing "?" after
the expression to match cast of argument to free-like function.

Signed-off-by: Jim Meyering <address@hidden>
---
 ChangeLog                        |    6 ++++++
 build-aux/useless-if-before-free |    6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 766cc3f..fb3db22 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-04-29  Jim Meyering  <address@hidden>
+
+       Fix broken useless-if-before-free script.
+       * build-aux/useless-if-before-free: Fix typo: missing "?" after
+       the expression to match cast of argument to free-like function.
+
 2008-04-29  Eric Blake  <address@hidden>

        Use new header.
diff --git a/build-aux/useless-if-before-free b/build-aux/useless-if-before-free
index 626d19a..89e7859 100755
--- a/build-aux/useless-if-before-free
+++ b/build-aux/useless-if-before-free
@@ -2,7 +2,7 @@
 # Detect instances of "if (p) free (p);".
 # Likewise for "if (p != NULL) free (p);".  And with braces.

-my $VERSION = '2008-03-12 13:06'; # UTC
+my $VERSION = '2008-04-29 17:55'; # UTC
 # The definition above must lie within the first 8 lines in order
 # for the Emacs time-stamp write hook (at end) to update it.
 # If you change this file with Emacs, please let the write hook
@@ -123,8 +123,8 @@ EOF
         {
           if ($line =~
               /\b(if\s*\(\s*(\S+?)(?:\s*!=\s*NULL)?\s*\)
-               (?:   \s*$regexp\s*\((?:\s*\([^)]+\))\s*\2\s*\)|
-                \s*\{\s*$regexp\s*\((?:\s*\([^)]+\))\s*\2\s*\)\s*;\s*\}))/sx)
+               (?:   \s*$regexp\s*\((?:\s*\([^)]+\))?\s*\2\s*\)|
+                \s*\{\s*$regexp\s*\((?:\s*\([^)]+\))?\s*\2\s*\)\s*;\s*\}))/sx)
             {
               $found_match = 1;
               $list
--
1.5.5.1.68.gbdcd8