Re: [RFE] function to read a file descriptor

[Ralf Wildenhues]

* Debarshi Ray wrote on Wed, Aug 20, 2008 at 09:40:13PM CEST:
> Oops sorry! This one is hopefully better.

I don't think you want to recv more than BUFSIZ bytes; and then you
shouldn't need to call realloc for every recv.  Only when the next recv
answer will not fit in the current buffer size any more, do you need to
allocate more memory.

Also, if this is to be a library function, it should not call xrealloc
nor error at all but indicate an error to the calling function.

Cheers,
Ralf

> size_t
> recvbuf (int sockfd, void **buffer, size_t *size)
> {
>   size_t block = BUFSIZ;
>   size_t count = 0;
>   ssize_t nread;
> 
>   if (*buffer == NULL)
>     *size = block;
> 
>   for (;;)
>     {
>       *buffer = xrealloc (*buffer, *size);
>       nread = recv (sockfd, *buffer + count, block, 0);
> 
>       if (nread == -1)
>         error (EXIT_FAILURE, errno, "recv");
> 
>       count += nread;
> 
>       if (nread < block)
>         break;
>       else
>         {
>           block = (*size / 2 > BUFSIZ) ? *size / 2 : BUFSIZ;
>           *size += block;
>         }
>     }
> 
>   return count;
> }