Re: GNUmakefile: git-version-gen, maintainer-check, install

[Eric Blake]

Denny Joel E <jdenny <at> cs.clemson.edu> writes:

> > Well, I tried to make it a hard error, so that it would be the only
> > output, but others on the list convinced me to reduce it back to a
> > warning.  I don't know of any GNU make construct to make it appear last.
> > Maybe we just insert a sleep 10 after printing the warning, so that the
> > interactive user has time to notice the message and Ctrl-C the build,
> > while an unattended install eventually proceeds?
> 
> That would work for me.

What does everyone think of this patch?

From: Eric Blake <address@hidden>
Date: Wed, 27 Aug 2008 08:34:59 -0600
Subject: [PATCH] GNUmakefile: pause after warning messages

* top/GNUmakefile (_curr-ver): Pause to allow time to read warning
messages.  Split version update rules...
(version): ...into a target.
Suggested by Joel E. Denny.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog       |    8 ++++++++
 top/GNUmakefile |   12 +++++++++---
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1f25783..6a2f02e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-08-27  Eric Blake  <address@hidden>
+
+       GNUmakefile: pause after warning messages
+       * top/GNUmakefile (_curr-ver): Pause to allow time to read warning
+       messages.  Split version update rules...
+       (version): ...into a target.
+       Suggested by Joel E. Denny.
+
 2008-08-26  Eric Blake  <address@hidden>
 
        doc/INSTALL: resync from autoconf
diff --git a/top/GNUmakefile b/top/GNUmakefile
index 4b4cf15..34239af 100644
--- a/top/GNUmakefile
+++ b/top/GNUmakefile
@@ -62,6 +62,7 @@ ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
     ifneq ($(_curr-ver),$(VERSION))
       ifeq ($(_curr-ver),UNKNOWN)
         $(info WARNING: unable to verify if $(VERSION) is correct version)
+        _dummy := $(shell sleep 10)
       else
         ifneq (,$(_is-install-target))
           # GNU Coding Standards state that 'make install' should not cause
@@ -71,17 +72,22 @@ ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
           # warn when installing a version string that is out of date; the user
           # should run 'autoreconf' (or something like 'make distcheck') to
           # fix the version, 'make all' to propagate it, then 'make install'.
-          $(info WARNING: version string $(VERSION) is out of date; run 
autoreconf -f to fix it)
+          $(info WARNING: version string $(VERSION) is out of date;)
+          $(info run '$(MAKE) version' to fix it)
+          _dummy := $(shell sleep 10)
         else
           $(info INFO: running autoreconf for new version string: $(_curr-ver))
-          _dummy := $(shell cd $(srcdir) && rm -rf autom4te.cache .version \
-            && $(_autoreconf))
+          _dummy := $(shell $(MAKE) $(AM_MAKEFLAGS) version)
         endif
       endif
     endif
   endif
 endif
 
+.PHONY: version
+version:
+       cd $(srcdir) && rm -rf autom4te.cache .version && $(_autoreconf)
+
 else
 
 .DEFAULT_GOAL := abort-due-to-no-makefile
-- 
1.6.0