[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use unlocked io in getdelim
From: |
Bruno Haible |
Subject: |
Re: [PATCH] use unlocked io in getdelim |
Date: |
Fri, 29 Aug 2008 12:19:45 +0200 |
User-agent: |
KMail/1.5.4 |
Simon Josefsson wrote:
> I'd prefer to solve it by having m4 code check whether
> the non-portable code works or not, and then AC_SUBST in the proper
> replacement function, either getline-fast.c or getline-slow.c. This
> allows a gnulib module 'getline-slow' for when people prefer a small and
> simple implementation over a faster but more complex.
Even in this scenario, I would prefer a constant conditional that chooses
among two implementation. This allows to keep common parts of the two
implementations in one place, and guarantees that the unused code is
still syntactically checked by the compiler - guarding against bitrot.
Bruno
- Re: getndelim2 license, (continued)
- Re: getndelim2 license, Bruno Haible, 2008/08/28
- Re: getndelim2 license, Paolo Bonzini, 2008/08/29
- Re: getndelim2 license, Jim Meyering, 2008/08/29
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Bruno Haible, 2008/08/28
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/28
- Re: [PATCH] use unlocked io in getdelim,
Bruno Haible <=
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/29