[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mbsrtowcs-state.c, wcsrtombs-state.c: avoid compilation fail
From: |
Jim Meyering |
Subject: |
Re: [PATCH] mbsrtowcs-state.c, wcsrtombs-state.c: avoid compilation failure |
Date: |
Tue, 28 Apr 2009 18:54:45 +0200 |
Jim Meyering wrote:
> Eric Blake wrote:
>> Jim Meyering <jim <at> meyering.net> writes:
>>> @@ -20,4 +20,4 @@
>>> #include <wchar.h>
>>>
>>> /* Internal state used by the functions mbsrtowcs() and mbsnrtowcs(). */
>>> -mbstate_t _gl_mbsrtowcs_state = 0;
>>> +mbstate_t _gl_mbsrtowcs_state = { 0, };
>>
>> Is this correct for all platforms? If I read Posix correctly, mbstate_t can
>> be
>> a numeric type rather than a struct.
>
> Good point.
> Maybe we can use something like this instead:
>
> static mbstate_t _dummy;
> mbstate_t _gl_mbsrtowcs_state = _dummy;
FYI, while the above works fine inside a function,
it is invalid at global scope, since the RHS is not constant.
So we're back to my original proposal of using = {0,}.