Re: brand new failure: ln/misc

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 9/4/2009 3:26 PM:
> I don't have time to investigate right now, so...
> 
> ======================================================
>    GNU coreutils 7.5.55-860a3: tests/test-suite.log
> ======================================================
> 
> 1 of 350 tests failed.  (36 tests were not run).

Bummer.  I think I see the root cause - I botched the logic in
link-follow.m4 (it didn't help that a compilation failure looked the same
as desired status); so I'm applying this to gnulib, plus a submodule bump
in coreutils (but I'll run more testing there first).

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqhivAACgkQ84KuGfSFAYDz8wCfYdOjGLocmVWXrT2UVKt2qk9k
ksgAoMoSv9QJeG83QxVbZehV/qyDq437
=n6kH
-----END PGP SIGNATURE-----

>From 8a0efd04dc9583c96b4a0d3c311ff216e07dcdcd Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Fri, 4 Sep 2009 15:40:22 -0600
Subject: [PATCH] link-follow: fix logic bug in prior patch

* m4/link-follow.m4 (gl_FUNC_LINK_FOLLOWS_SYMLINK): Fix bug that
reversed sense of yes and no in prior patch.  Avoid confusing
compilation failure with desired semantics.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog         |    5 +++++
 m4/link-follow.m4 |   12 ++++++------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e63d09e..193ec7f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2009-09-04  Eric Blake  <address@hidden>

+       link-follow: fix logic bug in prior patch
+       * m4/link-follow.m4 (gl_FUNC_LINK_FOLLOWS_SYMLINK): Fix bug that
+       reversed sense of yes and no in prior patch.  Avoid confusing
+       compilation failure with desired semantics.
+
        link-follow: accomodate mingw and cross-compilation
        * m4/link-follow.m4 (gl_AC_FUNC_LINK_FOLLOWS_SYMLINK): Rename...
        (gl_FUNC_LINK_FOLLOWS_SYMLINK): ...to this.  Change
diff --git a/m4/link-follow.m4 b/m4/link-follow.m4
index eb98c3b..48885ea 100644
--- a/m4/link-follow.m4
+++ b/m4/link-follow.m4
@@ -1,4 +1,4 @@
-# serial 13
+# serial 14
 dnl Run a program to determine whether link(2) follows symlinks.
 dnl Set LINK_FOLLOWS_SYMLINKS accordingly.

@@ -60,17 +60,17 @@ AC_DEFUN([gl_FUNC_LINK_FOLLOWS_SYMLINK],

          /* If the dev/inode of hard and file are the same, then
             the link call followed the symlink.  */
-         return SAME_INODE (sb_hard, sb_file) ? 0 : 1;
+         return SAME_INODE (sb_hard, sb_file) ? 1 : 0;
        }
       ]])],
-       [gl_cv_func_link_follows_symlink=yes],
-       [gl_cv_func_link_follows_symlink=no],
+       [gl_cv_func_link_follows_symlink=no], dnl GNU behavior
+       [gl_cv_func_link_follows_symlink=yes], dnl Followed link/compile failed
        [gl_cv_func_link_follows_symlink=unknown] dnl We're cross compiling.
       )
     ])
     case $gl_cv_func_link_follows_symlink in
-      yes) ;;
-      no) gl_link_follows_symlinks=1 ;;
+      yes) gl_link_follows_symlinks=1 ;;
+      no) ;; # already defaulted to 0
       *) gl_link_follows_symlinks=-1 ;;
     esac
   fi
-- 
1.6.3.3.334.g916e1