Re: new snapshot available: coreutils-7.5.65-61cc6

[Jim Meyering]

Eric Blake wrote:
> Eric Blake <ebb9 <at> byu.net> writes:
>
>> According to Pádraig Brady on 9/7/2009 6:32 PM:
>> > gnulib 52c658e seems to have removed #include "openat.h" from fstatat.c
>> > but not replaced it with #include <fcntl.h>
>>
>> Yep; and only Solaris had the problem, because that is the only platform
>> with broken fstatat (the other platforms either lack it or it works
>> entirely).  Fixed as follows; coreutils needs to update the gnulib submodule.
>
> euidaccess.c is also broken; it refers to AT_EACCESS without using <fcntl.h>.
>
>
> From: Eric Blake <address@hidden>
> Date: Tue, 8 Sep 2009 08:24:11 -0600
> Subject: [PATCH] euidaccess: fix compilation error
>
> * lib/euidaccess.c (includes): Add <fcntl.h>, for AT_EACCESS.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  ChangeLog        |    3 +++
>  lib/euidaccess.c |    1 +
>  2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 9316020..8cf27c0 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,8 @@
>  2009-09-08  Eric Blake  <address@hidden>
>
> +     euidaccess: fix compilation error
> +     * lib/euidaccess.c (includes): Add <fcntl.h>, for AT_EACCESS.

For what system?
Two I checked (Solaris 10 and freebsd 6) work fine
because they lack faccessat and thus #ifdef-out the use of AT_EACCESS:
It'd have to be a system that lacks euidaccess, yet that provides
faccessat.  Yet, it appears that all systems that lack euidaccess
also lack faccessat.

Regardless, this looks like a fine change.

The alternative would be to remove that #if HAVE_FACCESSAT block:

    int
    euidaccess (const char *file, int mode)
    {
    #if HAVE_FACCESSAT
      return faccessat (AT_FDCWD, file, mode, AT_EACCESS);
    #elif defined EFF_ONLY_OK
    ...