Re: size_max

[Eric Blake]

Simon Josefsson <simon <at> josefsson.org> writes:

> So how about this patch?
> 
> Of course, stdint.h has to define SIZE_MAX on these systems to make sure
> it will still work.  But I suppose we'll notice if it doesn't already.

stdint.in.h already takes care of SIZE_MAX.

> +2009-10-06  Simon Josefsson  <simon <at> josefsson.org>
> +
> +     * lib/size_max.h: Remove file.
> +     * modules/size_max: Drop size_max.h.
> +     * NEWS: Explain.

Fix these nits, then I think it's ready to apply...

> 
> +2009-10-06  size_max        The header file "size_max.h" has been removed,
> +                            use <stdint.h> from the stdint.h module instead.

s/stdint.h module/stdint module/

> diff --git a/lib/size_max.h b/lib/size_max.h
> deleted file mode 100644
> index ed0bc13..0000000
> --- a/lib/size_max.h
> +++ /dev/null

> diff --git a/modules/size_max b/modules/size_max
> index 13554ae..bf35aeb 100644
> --- a/modules/size_max
> +++ b/modules/size_max
> @@ -2,7 +2,6 @@ Description:
>  Provide SIZE_MAX.
> 
>  Files:
> -m4/size_max.m4
>  lib/size_max.h

Oops - you meant to stop distributing lib/size_max.h but keep m4/size_max.m4 
since gl_SIZE_MAX is still a valid configure macro.

> 
>  Depends-on:

I debated whether we need to add stdint here.  But I'm guessing not, so that 
the xsize module will continue to work without dragging in the stdint 
replacement header.  So the NEWS is sufficient to tell the majority of clients 
to use the correct module in the first place.

Then, are you also willing to prepare the followup patch to kill the self-
definition of SIZE_MAX throughout the various modules willing to depend on the 
stdint module?

-- 
Eric Blake