Re: 4 test failures on freebsd8-rc2

[Jim Meyering]

Eric Blake wrote:
> According to Eric Blake on 11/2/2009 8:37 PM:
>>> test-rename.h:141: assertion failed
>>
>> Looks like a case of BSD returning a non-standard errno, but where it is
>> easier to teach the test one more errno to allow than to wrap the BSD bug.
>>  Now, if only I knew which errno to ignore...
>
> ENOTEMPTY.  Which is weird, since both directories were indeed empty (per
> POSIX, the error should have been EINVAL).  But fixing that proved that
> (you guessed it) FreeBSD mishandles trailing slash on
> symlink-to-non-directory.  So here's the next in a series (I'm betting
> that unlink will also need fixing, and probably a few others...)
...
> Subject: [PATCH] rename: detect FreeBSD bug
>
> rename("link-to-file/","new") mistakenly succeeded.
>
> * m4/rename.m4 (gl_FUNC_RENAME): Also detect FreeBSD bug with
> slash on symlink.
> * modules/renameat-tests (Depends-on): Add filenamecat.
> * tests/test-rename.h (test_rename): Allow one more errno.
> * doc/posix-functions/rename.texi (rename): Document the bug.

That looks fine.  Thanks!

If I'd known this was coming so quickly, I would have delayed
making the coreutils snapshot.

Let me know when you're done: maybe I'll make one more
before the release.