[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: diffseq: Introduce EQUAL_IDX for comparing indexes instead of elemen
From: |
Bruno Haible |
Subject: |
Re: diffseq: Introduce EQUAL_IDX for comparing indexes instead of elements |
Date: |
Tue, 20 Apr 2010 00:08:48 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Eric,
Eric Blake wrote:
> > + It is also possible to you this file with abstract arrays. In this
> > case,
>
> s/you/use/
Oops, thanks. Corrected.
> > +#ifdef ELEMENT
> > ELEMENT const *const xv = ctxt->xvec; /* Still more help for the
> > compiler. */
> > ELEMENT const *const yv = ctxt->yvec; /* And more and more . . . */
> > + #define XREF_YREF_EQUAL(x,y) EQUAL (xv[x], yv[y])
>
> Isn't the more typical style:
>
> # define XREF...
>
> rather than the leading whitespace?
Yes, the more typical style is based on K&R C, which didn't allow the '#' to be
indented like the rest. This is fixed in ANSI C, and all ANSI C compilers
support indented preprocessor directives. I am deliberately experimenting, in
order to see where this freedom of formatting can yield more legible code.
Bruno