[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature request: detect CPU instruction set
From: |
Bruno Haible |
Subject: |
Re: feature request: detect CPU instruction set |
Date: |
Tue, 31 Aug 2010 22:00:46 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Sam,
> you say you want to cache just once.
> fine, remove AC_CACHE_CHECK.
Yes, I removed the AC_CACHE_CHECK invocations and then found that there was
no good reason any more to keep the CL_CACHE_EGREP_CPP and CL_SET_CPU_ABI
macros.
> I have
> dnl CL_CACHE_EGREP_CPP(what,variable,condition)
> dnl CL_SET_CPU_ABI(what,variable,condition,yes_abi,no_abi)
> which make the code much more readable.
It apparently depends for whom the code should be readable. I find that
without these macros, anyone fluent with the AC_EGREP_CPP from Autoconf
can easily read the code, and the question "what are the possible
assignments to the gl_cv_host_cpu_c_abi variable" can be answered by a
plain string search.
So, except for code style, you are fine with that proposed module?
Bruno