|
From: | Eric Blake |
Subject: | Re: git log -> changelog |
Date: | Thu, 02 Sep 2010 15:23:57 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.2 |
On 09/02/2010 03:16 PM, Charles Wilson wrote:
On 9/2/2010 5:08 PM, Eric Blake wrote:On 09/02/2010 03:00 PM, Charles Wilson wrote:Two people worked on a single patch, or someone submitted it, and then one of the people with commit access modified the patch slightly. The GCS says you should do this, in the ChangeLog: =========================================== 2010-09-02 John Original Submitter<...> Steve Committer Rewrite<...> <<<=== can't do thisWell, if you go by git's Signed-off-by tags as a way of generating those lines, it would be possible.Ah, but then how do you distinguish between a chain of Signed-off-by labels -- as in the Linux kernel, where various subsystem maintainers also have to sign off on patches, in the sense of "I certify that this is OK, and it has proper approvals, and has been reviewed, (FSF: and the author has a copyright assignment). vs. "and I modified the actual contents of the patch a little bit"
The git pages are clear that S-O-B has project-dependent interpretation. Coreutils currently doesn't even use it (the only people with commit privileges to the master coreutils.git have FSF copyright, and it is assumed that they are each trustworthy enough to do due diligence in verifying that patches from other contributors meet copyright rules, without relying on any markup in the commit message itself).
But if we wanted, we could adopt a policy that S-O-B on GNU projects using the gitlog-to-changelog conversion implies (partial) authorship, above and beyond the --author.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |