[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: don't augment PATH in TESTS_ENVIRONMENT
From: |
Jim Meyering |
Subject: |
Re: don't augment PATH in TESTS_ENVIRONMENT |
Date: |
Sat, 04 Sep 2010 17:45:24 +0200 |
Bruno Haible wrote:
>> Good catch. Thanks for doing that.
>> Your patch looks right
>
> OK, applied.
I've just pushed this correction.
Sorry I didn't catch it in review.
>From 3389c116ca7f63bcad9f9000087cdae5774b1ec2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 4 Sep 2010 17:43:39 +0200
Subject: [PATCH] avoid coreutils "make distcheck" failure
Coreutils tests with an absolute build directory name that contains
a space. Not quoting this directory name caused a failure.
* tests/test-vc-list-files-git.sh: Quote PATH dir name.
* tests/test-vc-list-files-cvs.sh: Likewise.
---
ChangeLog | 8 ++++++++
tests/test-vc-list-files-cvs.sh | 2 +-
tests/test-vc-list-files-git.sh | 2 +-
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0ef095c..6616cbb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2010-09-04 Jim Meyering <address@hidden>
+
+ avoid coreutils "make distcheck" failure
+ Coreutils tests with an absolute build directory name that contains
+ a space. Not quoting this directory name caused a failure.
+ * tests/test-vc-list-files-git.sh: Quote PATH dir name.
+ * tests/test-vc-list-files-cvs.sh: Likewise.
+
2010-09-04 Bruno Haible <address@hidden>
gnulib-tool: Avoid error when run in a package without Makefile.am.
diff --git a/tests/test-vc-list-files-cvs.sh b/tests/test-vc-list-files-cvs.sh
index f9c0fca..017b8d2 100755
--- a/tests/test-vc-list-files-cvs.sh
+++ b/tests/test-vc-list-files-cvs.sh
@@ -17,7 +17,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
: ${srcdir=.}
-. "$srcdir/init.sh"; path_prepend_ $abs_aux_dir .
+. "$srcdir/init.sh"; path_prepend_ "$abs_aux_dir" .
tmpdir=vc-cvs
repo=`pwd`/$tmpdir/repo
diff --git a/tests/test-vc-list-files-git.sh b/tests/test-vc-list-files-git.sh
index 47892a5..262d2ea 100755
--- a/tests/test-vc-list-files-git.sh
+++ b/tests/test-vc-list-files-git.sh
@@ -17,7 +17,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
: ${srcdir=.}
-. "$srcdir/init.sh"; path_prepend_ $abs_aux_dir .
+. "$srcdir/init.sh"; path_prepend_ "$abs_aux_dir" .
tmpdir=vc-git-$$
GIT_DIR= GIT_WORK_TREE=; unset GIT_DIR GIT_WORK_TREE
--
1.7.2.2.566.g36af9
- don't augment PATH in TESTS_ENVIRONMENT, Bruno Haible, 2010/09/04
- Re: don't augment PATH in TESTS_ENVIRONMENT, Jim Meyering, 2010/09/04
- Re: don't augment PATH in TESTS_ENVIRONMENT, Bruno Haible, 2010/09/04
- Re: don't augment PATH in TESTS_ENVIRONMENT,
Jim Meyering <=
- Re: absolute build directory with spaces, Bruno Haible, 2010/09/04
- Re: absolute build directory with spaces, Stefano Lattarini, 2010/09/04
- Re: absolute build directory with spaces, Jim Meyering, 2010/09/04
- Re: absolute build directory with spaces, Stefano Lattarini, 2010/09/04
- Re: absolute build directory with spaces, Ralf Wildenhues, 2010/09/05
- [RFC] Make build and install dirs used by distcheck configurable. (was: Re: absolute build directory with spaces), Stefano Lattarini, 2010/09/06
- Re: absolute build directory with spaces, Jim Meyering, 2010/09/04