|
From: | Paolo Bonzini |
Subject: | Re: [PATCH] regex: Pass the system regex if its only problem is 32-bit regoff_t |
Date: | Thu, 09 Sep 2010 17:44:55 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 |
On 09/09/2010 05:24 PM, Bruno Haible wrote:
This would make no sense to me.
I know, I'm trying to be pragmatic. I prefer a gigabyte-crippled grep than a feature-crippled grep.
It would be better to push the glibc people so that they offer some preprocessor macro that makes regoff_t 64-bit wide - like it was done for off_t. Would glibc need to export additional symbols for this? Yes. Would a compiled glibc need to contain two copies of the regex code? No, the 32-bit version could be a thin wrapper around the 64-bit version.
The glibc bug at http://sourceware.org/bugzilla/show_bug.cgi?id=5945 says "This is known but obviously cannot easily be fixed. Suspended until somebody takes this serious to actually take a stab at a solution".
I guess that counts as "patches are welcome". :) Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |