Re: [PATCH] Add an implementation of gnulib's canonicalize_file_name for mingw.

[Jan Nieuwenhuizen]

Bruno Haible schreef op di 01-02-2011 om 10:46 [+0100]:

Hi Bruno,

> In which respect did you find it useless for mingw?

In that, when given an absolute file name, such as

   c:/program files/lilypond/usr/share/guile/2.0/ice-9/boot-9.scm

it returns NULL.  It also returns NULL when given the CWD or a
simple drive letter, such as C: or C:/.  When given a local file
name "baz", it returns something like

    C:\foo\bar/baz

which is certainly not canonical.  Don't you think this is
pretty useless?

> I occasionally run it on mingw, and I don't remember having seen a
> test failure.

One reason could be that there is no single sensible test for
mingw.  It's still strange because for me, test-canonicalize-lgpl.exe
currently aborts in three places.

Attached are patches to get it to run, a patch adding some sane
tests for Mingw (ie, using a file name that includes a drive
letter), and a simple, much less broken implementation that I use
for running guile 1.9.

> So, before changing the implementation, I'd like to
> know what went wrong, and have a patch extend the unit test at the
> same time as the implementation.

It's good to see how thorough you are, even though I still think
this is not much of a change as much as a first implementation.

See attached, greetings,
Jan

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl

0001-Enable-cross-building-along-with-basic-HACKING-instr.patch
Description: Text Data

0002-canonicalize-lgpl-Use-del-instead-of-rm.-Fixes-abort.patch
Description: Text Data

0003-canonicalize-lgpl-Skip-symlink-tests.-Fixes-aborting.patch
Description: Text Data

0004-canonicalize-lgpl-Skip-cleanup-using-remove.-Fixes-a.patch
Description: Text Data

0005-canonicalize-lgpl-Add-basic-sanity-checks-for-mingw.patch
Description: Text Data

0006-canonicalize-lgpl-Add-an-implementation-for-canonica.patch
Description: Text Data