Re: [PATCH] di-set, ino-map: new modules, from coreutils

[Eric Blake]

On 02/07/2011 10:29 PM, Paul Eggert wrote:
> On 02/07/2011 04:45 PM, Bruno Haible wrote:
>> In lib/di-set.c, function di_ent_hash, there is the assumption that
>> dev_t is an integral type. But POSIX
>> <http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html>
>> does not guarantee this. It could also be a floating-point type.
> 
> Let's leave that alone, or at best just put in a comment saying
> we assume it's integral.  Nobody uses floating-point for dev_t,
> and if anybody did, there would be a compile-time error anyway,
> so no real harm done.  In that sense dev_t is the same as time_t,
> which we also assume is an integer despite POSIX's saying it might
> be floating.

Actually, POSIX 2008 TC1 will require that time_t be integral:
http://austingroupbugs.net/view.php?id=327

So I've just created this to do likewise for dev_t:
http://austingroupbugs.net/view.php?id=376

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature