[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-exclude.c: remove unmatched #endif
From: |
Jim Meyering |
Subject: |
Re: [PATCH] test-exclude.c: remove unmatched #endif |
Date: |
Mon, 21 Feb 2011 00:22:56 +0100 |
Paul Eggert wrote:
> On 02/20/2011 03:12 PM, Jim Meyering wrote:
>> I do see the aesthetic value in indenting the entire cpp directive,
>> but from a consistency standpoint, it is counterproductive.
>
> I'd rather that we were consistent the other way, and
> indented cpp directives like we indent other code.
>
> Admittedly that sort of indenting is rare in gnulib,
> but I have some qualms about removing it purely for
> consistency's sake. It's not just aesthetics; it's
> also readability.
This is yet another good reason to avoid use of in-function #defines,
when possible, and to move them "up"/out, otherwise.
- [PATCH] test-exclude.c: remove unmatched #endif, Jim Meyering, 2011/02/20
- Re: [PATCH] test-exclude.c: remove unmatched #endif, Bruno Haible, 2011/02/20
- Re: [PATCH] test-exclude.c: remove unmatched #endif, Jim Meyering, 2011/02/20
- Re: preprocessor directive indentation, cppi, Bruno Haible, 2011/02/20
- Re: preprocessor directive indentation, cppi, Bruce Korb, 2011/02/20
- Re: preprocessor directive indentation, cppi, Jim Meyering, 2011/02/21
- Re: preprocessor directive indentation, Bruno Haible, 2011/02/20