Re: [PATCH 3/3] canonicalize-lgpl: Use rname for file name variable (was rpath).

[Bruno Haible]

Hi Jan,

> 2011-02-25  Jan Nieuwenhuizen  <address@hidden>
> 
>       * lib/canonicalize-lgpl.c (__realpath): Rename rpath to rname, as
>       per GNU coding standards for file name variables.

There's a misunderstanding here: In the GNU standards [1] section 5.4
"Naming Variables, Functions, and Files" there is nothing that prevents a
variable 'rpath'. In [1] section 6.1 "GNU Manuals" it is written that we
shouldn't confuse the user by using the word "pathname" to mean two different
things _in_documentation_.

Here's its about a function '__realpath' where the meaning of "path" is the
same as in POSIX [2]. I think we will not succeed in cleaning up the meaning
of "pathname" in POSIX. Therefore it's ok to have a variable called 'rpath'
in a place like this.

Additionally, we may occasionally sync this file with
glibc/stdlib/canonicalize.c. A renamed variable just gets in the way when
doing this task.

Bruno

[1] http://www.gnu.org/prep/standards/standards.html
[2] http://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html
-- 
In memoriam Stephan Brassloff <http://de.wikipedia.org/wiki/Stephan_Brassloff>