Re: [PATCH] stdio: simplify by removing some files and dependencies

[Bruno Haible]

Hi Paul,

> Here's a proposed patch to simplify stdio so that, for example,
> Emacs and coreutils won't need m4/asm-underscore.m4 or
> lib/stdio-write.c.

The patch is fine and good.

But actually it's two different, independent changes (even though they
have the same motivation). I find it preferrable to commit independent
changes as separate commits; it makes things clearer when analyzing
the history later. Like this:

       stdio: simplify by removing some files and dependencies
       * m4/fseeko.m4 (gl_STDIN_LARGE_OFFSET): Moved here, from ...
       * m4/stdio_h.m4 (gl_STDIN_LARGE_OFFSET): ... here, because
       only fseek and ftell need it.
       * modules/ftello (Files): Add m4/fseeko.m4, for gl_STDIN_LARGE_OFFSET.

       stdio: simplify by removing some files and dependencies
       * m4/stdio_h.m4 (gl_STDIO_H): Do not require gl_ASM_SYMBOL_PREFIX, since
       this symbol is needed only if printf is replaced.
       * m4/printf-posix-rpl.m4 (gl_REPLACE_PRINTF):
       Require gl_ASM_SYMBOL_PREFIX.
       * modules/printf-posix (Files): Add m4/asm-underscore.m4.
       * modules/sigpipe (Files): Likewise.  Also, add m4/stdio-write.c.
       (Depends-on): Add 'raise'.
       (configure.ac): Require gl_ASM_SYMBOL_PREFIX.
       * modules/stdio (Files): Remove lib/stdio-write.c,
       m4/asm-underscore.m4.
       (Depends-on): Remove 'raise'.

Bruno
-- 
In memoriam Olof Palme <http://en.wikipedia.org/wiki/Olof_Palme>