[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: latest fclose.c evokes new warning/error
|
From: |
Eric Blake |
|
Subject: |
Re: latest fclose.c evokes new warning/error |
|
Date: |
Wed, 11 May 2011 11:26:38 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 05/11/2011 11:22 AM, Jim Meyering wrote:
> Hi Eric,
>
> I've just tried the latest from gnulib in coreutils,
> and bootstrap+build failed with this:
>
> fclose.c: In function 'rpl_fclose':
> fclose.c:33:7: error: variable 'saved_errno' set but not used
> [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Isn't that highlighting a real bug? Currently, in the !WINDOWS_SOCKETS code,
> rpl_fclose may return 0 in spite of a preceding failed fflush.
Yep. I should have a fix shortly.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature