Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities.

[Jim Meyering]

James Youngman wrote:
> * lib/getopt.c (_getopt_internal_r): Merge glibc change printing
> the ambiguous options when an ambiguous prefix is given. This was
> http://sourceware.org/bugzilla/show_bug.cgi?id=7101.  The merged
> glibc change was
> http://sourceware.org/git/?p=glibc.git;a=commit;h=bd25564e1e98910ed69043ed6a6f884ce60e5780.
...
> diff --git a/lib/getopt.c b/lib/getopt.c
..
> @@ -550,6 +592,13 @@ _getopt_internal_r (int argc, char **argv, const char 
> *optstring,
>            return '?';
>          }
>
> +      while (ambig_list != NULL)
> +        {
> +          struct option_list *pn = ambig_list->next;
> +          free (ambig_list);
> +          ambig_list = pn;
> +        }
> +      <<<--- trailing spaces
>        if (pfound != NULL)
>          {
>            option_index = indfound;

Hi James,

Thanks for doing that.
One nit that emacs highlights (while reading this via Gnus)
is that there is a line with trailing spaces above.

Other than that, it looks fine.