Re: [PATCH 06/10] * modules/pselect: Add select, LIBSOCKET.

[Stefano Lattarini]

Hello Paul.  Again another nit, please bear with me ...

On Wednesday 06 July 2011, Paul Eggert wrote:
> ---
>  ChangeLog       |    6 ++++--
>  modules/pselect |    2 ++
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index e815b29..ba7d0e4 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -2,8 +2,10 @@
>  
>       * lib/pselect.c (pselect): Use plain name, without "rpl_".
>       Don't #undef,  since we don't need any underlying pselect.
> -     * modules/pselect (Depends-on): Use our pselect.o if !HAVE_PSELECT.
> -     Both changes suggested by Bruno Haible.
> +     * modules/pselect (configure.ac): Use our pselect.o if !HAVE_PSELECT.
> +     (Depends-on): Add select.
> +     (Link): Add $(LIBSOCKET).
> +     These changes suggested by Bruno Haible.
>
Is it acceptable to edit the ChangeLog in this way?  I've always thought
that editing past ChangeLog entries was acceptable only to fix typos or
other blunders.

>       pselect: document better
>       * MODULES.html.sh (Support for systems lacking POSIX:2008): Add it.
> diff --git a/modules/pselect b/modules/pselect
> index 5f6291b..0e454d5 100644
> --- a/modules/pselect
> +++ b/modules/pselect
> @@ -7,6 +7,7 @@ m4/pselect.m4
>  
>  Depends-on:
>  sys_select
> +select          [test $HAVE_PSELECT = 0 || test $REPLACE_PSELECT = 1]
>  
>  configure.ac:
>  gl_FUNC_PSELECT
> @@ -21,6 +22,7 @@ Include:
>  <sys/select.h>
>  
>  Link:
> +$(LIBSOCKET)
>  
>  License:
>  LGPLv2+
> 

Regards,
  Stefano