[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ftell: two minor proposed patches
From: |
Bruno Haible |
Subject: |
Re: ftell: two minor proposed patches |
Date: |
Sun, 24 Jul 2011 22:56:24 +0200 |
User-agent: |
KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) |
Hi Paul,
> That being said, it may be that you prefer highlighting this particular
> conversion because it may narrow the value.
Yes, exactly.
> if (LONG_MIN <= offset && offset <= LONG_MAX)
> return /* (long) */ offset;
Fine me me. That's greppable and explains the preceding 'if'. Thanks!
Bruno
--
In memoriam Ezechiele Ramin <http://en.wikipedia.org/wiki/Ezechiele_Ramin>
- ftell: two minor proposed patches, Paul Eggert, 2011/07/24
- Re: ftell: two minor proposed patches, Bruno Haible, 2011/07/24
- Re: ftell: two minor proposed patches, Paul Eggert, 2011/07/24
- Re: ftell: two minor proposed patches, Bruno Haible, 2011/07/24
- Re: ftell: two minor proposed patches, Paul Eggert, 2011/07/24
- Re: ftell: two minor proposed patches, Jim Meyering, 2011/07/24
- Re: ftell: two minor proposed patches,
Bruno Haible <=
- Re: git, rebase, and ChangeLog, Bruno Haible, 2011/07/24