[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: split off module mkdirat from module openat
From: |
Jim Meyering |
Subject: |
Re: split off module mkdirat from module openat |
Date: |
Fri, 04 Nov 2011 13:36:09 +0100 |
Bruno Haible wrote:
> This patch is tested on a dozen of platforms as well, like the other ones.
>
> Here's a proposed fixup for some small omissions in the module descriptions.
> - fchmodat, fchownat, linkat, renameat use lib/at-func.c or lib/at-func2.c
> which requires openat_save_fail from module 'openat-die'.
> - openat uses lib/at-func.c, which includes <dirent.h>, thus requires module
> 'dirent'.
> - openat-tests: tests-openat.c includes test-open.h. Make sure this file
> is present, even if someone uses --avoid=open-tests.
> - renameat: No need to compile lib/at-func2.c if renameat() exists and
> is being overridden by gnulib.
>
> 2011-11-04 Bruno Haible <address@hidden>
>
> openat, fchmodat, fchownat, linkat, renameat: Fix dependencies.
> * modules/fchmodat (Depends-on): Add openat-die.
> * modules/fchownat (Depends-on): Likewise.
> * modules/linkat (Depends-on): Likewise.
> * modules/renameat (Depends-on): Likewise.
> (configure.ac): Don't compile ac-func2.c if REPLACE_RENAMEAT is 1.
> * modules/openat (Depends-on): Add dirent.
> * modules/openat-tests (Files): Add tests/test-open.h.
Those look fine. Glad you caught them.
Thanks for all the testing!