bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: canonicalize_file_name does not support MS-Windows style file names


From: Eli Zaretskii
Subject: Re: canonicalize_file_name does not support MS-Windows style file names
Date: Tue, 20 Nov 2012 18:37:55 +0200

> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
>       RP_MATCHES_RCVD autolearn=unavailable version=3.3.2
> Date: Tue, 20 Nov 2012 01:30:55 -0800
> From: Paul Eggert <address@hidden>
> CC: address@hidden, address@hidden, address@hidden
> 
> On 11/19/2012 07:46 PM, Eli Zaretskii wrote:
> > Where are the instructions for writing log entries for gnulib?  From
> > casual reading, it doesn't look like what standards.texi says, so I
> > presume there are some different rules.
> 
> Should be the standard GNU style.  We do use a leading single line
> to introduce it, as we automatically put the ChangeLog entry into
> git as the commit log, and the leading line works better with git.

Ah, okay.  That's easy, then.  Here:

2012-11-19  Eli Zaretskii  <address@hidden>

        Support MS-Windows "x:/foo\bar" file names in canonicalize_file_name.
        * canonicalize-lgpl.c: Include dosname.h.
        (__realpath): Use FILE_SYSTEM_PREFIX_LEN instead of assuming that
        the first slash is at the beginning of the file name.  Use
        ISSLASH, instead of a literal '/'.  Use IS_ABSOLUTE_FILE_NAME
        instead of comparing the first character with '/'.  Test for
        DOUBLE_SLASH_IS_DISTINCT_ROOT only if the file name does not begin
        with a drive letter.

        * canonicalize.c: Include dosname.h.
        (SLASHES): New macro.
        (canonicalize_filename_mode): Use FILE_SYSTEM_PREFIX_LEN instead
        of assuming that the first slash is at the beginning of the file
        name.  Use ISSLASH, instead of a literal '/'.  Use
        IS_ABSOLUTE_FILE_NAME instead of comparing the first character
        with '/'.  Test for DOUBLE_SLASH_IS_DISTINCT_ROOT only if the file
        name does not begin with a drive letter.  Use SLASHES instead of a
        literal string "/".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]