[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: How to force using a module in Gnulib? (expl() on OpenBSD)
From: |
Pádraig Brady |
Subject: |
Re: How to force using a module in Gnulib? (expl() on OpenBSD) |
Date: |
Wed, 16 Apr 2014 20:31:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 04/16/2014 06:33 PM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> + [case $host_os in
>> + mingw*) gl_cv_func_expl_buggy="guessing no";;
>> + *) gl_cv_func_expl_buggy="guessing yes";;
>> + esac])
>
> Sorry, what does this have to do with mingw? Why would we guess yes for
> (say) glibc?
>
> Instead, please guess no by default, and guess yes only on OpenBSD hosts.
Oh good point.
I thought it might have some unmentioned significance on mingw
but it's probably a copy & paste issue (from roundf.m4?),
especially since "guessing yes" would have never matched the
subsequent check anyway. I'll merge this in...
thanks!
Pádraig.
diff --git a/m4/expl.m4 b/m4/expl.m4
index 3e41589..fca810b 100644
--- a/m4/expl.m4
+++ b/m4/expl.m4
@@ -70,15 +70,16 @@ AC_DEFUN([gl_FUNC_EXPL],
isnan(expl(-0.4)); ]])],
[gl_cv_func_expl_buggy=no], [gl_cv_func_expl_buggy=yes],
[case $host_os in
- mingw*) gl_cv_func_expl_buggy="guessing no";;
- *) gl_cv_func_expl_buggy="guessing yes";;
+ openbsd*) gl_cv_func_expl_buggy="guessing yes";;
+ *) gl_cv_func_expl_buggy="guessing no";;
esac])
LIBS="$save_LIBS"
])
- if test $gl_cv_func_expl_buggy = yes; then
- gl_cv_func_expl_in_libm=no
- gl_cv_func_expl_no_libm=no
- fi
+ case "$gl_cv_func_expl_buggy" in
+ *yes)
+ gl_cv_func_expl_in_libm=no
+ gl_cv_func_expl_no_libm=no ;;
+ esac
fi
if test $gl_cv_func_expl_no_libm = yes \
|| test $gl_cv_func_expl_in_libm = yes; then
- How to force using a module in Gnulib? (expl() on OpenBSD), Assaf Gordon, 2014/04/14
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Paul Eggert, 2014/04/14
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Pádraig Brady, 2014/04/15
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Assaf Gordon, 2014/04/15
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Pádraig Brady, 2014/04/15
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Assaf Gordon, 2014/04/16
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Pádraig Brady, 2014/04/16
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Paul Eggert, 2014/04/16
- Re: How to force using a module in Gnulib? (expl() on OpenBSD),
Pádraig Brady <=
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Assaf Gordon, 2014/04/16
- Re: How to force using a module in Gnulib? (expl() on OpenBSD), Pádraig Brady, 2014/04/16