[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/21] spawn: do not include sched.h on OS/2 kLIBC
From: |
Bruno Haible |
Subject: |
Re: [PATCH 05/21] spawn: do not include sched.h on OS/2 kLIBC |
Date: |
Thu, 04 Dec 2014 00:03:10 +0100 |
User-agent: |
KMail/4.8.5 (Linux/3.2.0-64-generic; KDE/4.8.5; x86_64; ; ) |
KO Myung-Hun posted:
> 0001-sched-check-struct-sched_param-in-spawn.h-as-well.patch
Thanks. This looks much better now. Just two small improvements I'd like
to ask for:
- In m4/sched_h.m4, can you bump the marker "sched_h.m4 serial 6"
to "sched_h.m4 serial 7"?
- In lib/sched.in.h: We try to put all #includes before all type definitions
and variable/function declarations. (Otherwise the overriding of function
declarations may not work well in the long run.) Can you move the
#ifdef ... / # include <spawn.h>
near the #include <sys/types.h>, that is, before the
#if address@hidden@
Thanks.
Bruno