Re: [PATCH] printf: fix configure check on big endian systems

[Bruno Haible]

Pádraig Brady wrote on 2014-11-27:
> +     printf: fix configure check on big endian systems
> +     * m4/printf.m4 (gl_PRINTF_INFINITE_LONG_DOUBLE): Add missing bracket.

The same typo occurs in a few other places as well. I'm fixing them in the
same way.


2014-12-05  Bruno Haible  <address@hidden>

        Fix LDBL80_WORDS macro on big endian platforms.
        * m4/isfinite.m4 (gl_ISFINITEL_WORKS): Add missing parenthesis in
        LDBL80_WORDS macro.
        * m4/isinf.m4 (gl_ISINFL_WORKS): Likewise.
        * m4/isnanl.m4 (gl_FUNC_ISNANL_WORKS): Likewise.
        * tests/test-isfinite.c (test_isfinitel): Likewise.
        * tests/test-isinf.c (test_isinfl): Likewise.
        * tests/test-isnan.c (test_long_double): Likewise.
        * tests/test-isnanl.h (main): Likewise.
        * tests/test-snprintf-posix.h (LDBL80_WORDS): Add missing parenthesis.
        * tests/test-sprintf-posix.h (LDBL80_WORDS): Likewise.
        * tests/test-vasnprintf-posix.c (LDBL80_WORDS): Likewise.
        * tests/test-vasprintf-posix.c (LDBL80_WORDS): Likewise.
        Reported by Pádraig Brady.

diff --git a/ChangeLog b/ChangeLog
index 7379fa6..fb6723b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2014-12-05  Bruno Haible  <address@hidden>
+
+       Fix LDBL80_WORDS macro on big endian platforms.
+       * m4/isfinite.m4 (gl_ISFINITEL_WORKS): Add missing parenthesis in
+       LDBL80_WORDS macro.
+       * m4/isinf.m4 (gl_ISINFL_WORKS): Likewise.
+       * m4/isnanl.m4 (gl_FUNC_ISNANL_WORKS): Likewise.
+       * tests/test-isfinite.c (test_isfinitel): Likewise.
+       * tests/test-isinf.c (test_isinfl): Likewise.
+       * tests/test-isnan.c (test_long_double): Likewise.
+       * tests/test-isnanl.h (main): Likewise.
+       * tests/test-snprintf-posix.h (LDBL80_WORDS): Add missing parenthesis.
+       * tests/test-sprintf-posix.h (LDBL80_WORDS): Likewise.
+       * tests/test-vasnprintf-posix.c (LDBL80_WORDS): Likewise.
+       * tests/test-vasprintf-posix.c (LDBL80_WORDS): Likewise.
+       Reported by Pádraig Brady.
+
 2014-12-02  KO Myung-Hun  <address@hidden>
 
        git-version-gen: do not print new line characters
diff --git a/m4/isfinite.m4 b/m4/isfinite.m4
index 53ad909..bfd1ea3 100644
--- a/m4/isfinite.m4
+++ b/m4/isfinite.m4
@@ -1,4 +1,4 @@
-# isfinite.m4 serial 13
+# isfinite.m4 serial 14
 dnl Copyright (C) 2007-2014 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -94,7 +94,7 @@ int main ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/m4/isinf.m4 b/m4/isinf.m4
index 7174ace..4d844b0 100644
--- a/m4/isinf.m4
+++ b/m4/isinf.m4
@@ -1,4 +1,4 @@
-# isinf.m4 serial 9
+# isinf.m4 serial 10
 dnl Copyright (C) 2007-2014 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -101,7 +101,7 @@ int main ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/m4/isnanl.m4 b/m4/isnanl.m4
index 98b2b69..a26cc93 100644
--- a/m4/isnanl.m4
+++ b/m4/isnanl.m4
@@ -1,4 +1,4 @@
-# isnanl.m4 serial 17
+# isnanl.m4 serial 18
 dnl Copyright (C) 2007-2014 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -177,7 +177,7 @@ int main ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/tests/test-isfinite.c b/tests/test-isfinite.c
index 5d320ea..5b3f1dd 100644
--- a/tests/test-isfinite.c
+++ b/tests/test-isfinite.c
@@ -181,7 +181,7 @@ test_isfinitel ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/tests/test-isinf.c b/tests/test-isinf.c
index 2505c32..2a58257 100644
--- a/tests/test-isinf.c
+++ b/tests/test-isinf.c
@@ -187,7 +187,7 @@ test_isinfl ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/tests/test-isnan.c b/tests/test-isnan.c
index 9cb5e07..e769367 100644
--- a/tests/test-isnan.c
+++ b/tests/test-isnan.c
@@ -168,7 +168,7 @@ test_long_double (void)
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/tests/test-isnanl.h b/tests/test-isnanl.h
index 015b086..3b8fb3d 100644
--- a/tests/test-isnanl.h
+++ b/tests/test-isnanl.h
@@ -80,7 +80,7 @@ main ()
 # ifdef WORDS_BIGENDIAN
 #  define LDBL80_WORDS(exponent,manthi,mantlo) \
      { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-       ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+       ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
        (unsigned int) (mantlo) << 16                                        \
      }
 # else
diff --git a/tests/test-snprintf-posix.h b/tests/test-snprintf-posix.h
index ce8a6d2..1f723b3 100644
--- a/tests/test-snprintf-posix.h
+++ b/tests/test-snprintf-posix.h
@@ -34,7 +34,7 @@ have_minus_zero ()
 #ifdef WORDS_BIGENDIAN
 # define LDBL80_WORDS(exponent,manthi,mantlo) \
     { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-      ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+      ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
       (unsigned int) (mantlo) << 16                                        \
     }
 #else
diff --git a/tests/test-sprintf-posix.h b/tests/test-sprintf-posix.h
index 3871a1f..e23d34d 100644
--- a/tests/test-sprintf-posix.h
+++ b/tests/test-sprintf-posix.h
@@ -34,7 +34,7 @@ have_minus_zero ()
 #ifdef WORDS_BIGENDIAN
 # define LDBL80_WORDS(exponent,manthi,mantlo) \
     { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-      ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+      ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
       (unsigned int) (mantlo) << 16                                        \
     }
 #else
diff --git a/tests/test-vasnprintf-posix.c b/tests/test-vasnprintf-posix.c
index 4fd21c8..5f90947 100644
--- a/tests/test-vasnprintf-posix.c
+++ b/tests/test-vasnprintf-posix.c
@@ -47,7 +47,7 @@ have_minus_zero ()
 #ifdef WORDS_BIGENDIAN
 # define LDBL80_WORDS(exponent,manthi,mantlo) \
     { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-      ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+      ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
       (unsigned int) (mantlo) << 16                                        \
     }
 #else
diff --git a/tests/test-vasprintf-posix.c b/tests/test-vasprintf-posix.c
index 6a28cff..40cdfa9 100644
--- a/tests/test-vasprintf-posix.c
+++ b/tests/test-vasprintf-posix.c
@@ -46,7 +46,7 @@ have_minus_zero ()
 #ifdef WORDS_BIGENDIAN
 # define LDBL80_WORDS(exponent,manthi,mantlo) \
     { ((unsigned int) (exponent) << 16) | ((unsigned int) (manthi) >> 16), \
-      ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),    \
+      ((unsigned int) (manthi) << 16) | ((unsigned int) (mantlo) >> 16),   \
       (unsigned int) (mantlo) << 16                                        \
     }
 #else