[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Initialize the entire obstack struct [BZ #17919]
|
From: |
Siddhesh Poyarekar |
|
Subject: |
Re: [PATCH] Initialize the entire obstack struct [BZ #17919] |
|
Date: |
Tue, 3 Feb 2015 21:59:13 +0530 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
[I assume you intended to send this on list :) ]
On Tue, Feb 03, 2015 at 08:13:19AM -0800, Jim Meyering wrote:
> On Tue, Feb 3, 2015 at 7:47 AM, Siddhesh Poyarekar <address@hidden> wrote:
> > Done. Verified on s390x.
>
> Thanks for fixing that.
> Looks fine to me, modulo this:
>
> > + memset (h, 0, sizeof (struct obstack));
>
> I would use the following form, because it does not hard-code the type of *h.
> In this case it also more concise:
>
> memset (h, 0, sizeof *h);
Thanks, I'll fix this up and commit it to gnulib if Paul is OK with
it.
Siddhesh
pgp63lPjuW99O.pgp
Description: PGP signature