[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC
|
From: |
KO Myung-Hun |
|
Subject: |
Re: [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC |
|
Date: |
Fri, 15 Jan 2016 11:11:29 +0900 |
|
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Paul Eggert wrote:
> On 01/13/2016 06:23 PM, KO Myung-Hun wrote:
>
>> + if (__libc_Back_ioFHToPath (fd, path, sizeof (path)))
>
> Don't parenthesize the argument of sizeof here.
>
>> + sprintf (result, "%s/%s", path, file);
>
> This won't work if PATH or FILE is longer than INT_MAX bytes. Please
> just use memcpy or strcpy instead.
Updated.
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
0001-openat_proc_name-port-to-OS-2-kLIBC.patch
Description: Source code patch
- [PATCH v7 02/11] binary-io: don't put fd in binary mode if it is a console on EMX, (continued)
- [PATCH v7 02/11] binary-io: don't put fd in binary mode if it is a console on EMX, KO Myung-Hun, 2016/01/13
- [PATCH v7 01/11] stdint: check _INTPTR_T_DECLARED before defining intptr_t and uintptr_t, KO Myung-Hun, 2016/01/13
- [PATCH v7 03/11] pipe-filter-aux: undefine HAVE_SELECT on KLIBC, KO Myung-Hun, 2016/01/13
- [PATCH v7 04/11] w32spawn: clear SHELL_SPECIAL_CHARS and SHELL_SPACE_CHAR on OS/2 kLIBC, KO Myung-Hun, 2016/01/13
- [PATCH v7 05/11] wchar: fix 'conflicting types' error for `__wcwidth' on OS/2 kLIBC, KO Myung-Hun, 2016/01/13
- [PATCH v7 06/11] pipe_filter_ii_execute: port to OS/2 kLIBC, KO Myung-Hun, 2016/01/13
- [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC, KO Myung-Hun, 2016/01/13
[PATCH v7 07/11] dup, dup2, fcntl: support a directory fd on OS/2 kLIBC, KO Myung-Hun, 2016/01/13
[PATCH v7 10/11] utimes: detect utimes() correctly on OS/2 kLIBC, KO Myung-Hun, 2016/01/13
[PATCH v7 09/11] opendir, closedir, dirfd, fdopendir: port to OS/2 kLIBC, KO Myung-Hun, 2016/01/13
[PATCH v7 11/11] gnulib-tool: fall back into copy if symbolic link is not supported, KO Myung-Hun, 2016/01/13