[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Not distributing README-release automatically.
From: |
Mathieu Lirzin |
Subject: |
Re: Not distributing README-release automatically. |
Date: |
Tue, 14 Mar 2017 19:28:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi,
Bruno Haible <address@hidden> writes:
> Mathieu Lirzin wrote:
>> Here is the patch:
>
> Given the code from gnulib-tool that you are removing, I think:
>
>> +EXTRA_DIST += top/GNUmakefile
>
> This should read
>
> EXTRA_DIST += $(top_srcdir)/GNUmakefile
>
>> +EXTRA_DIST += top/maint.mk
>
> This should read
>
> EXTRA_DIST += $(top_srcdir)/maint.mk
>
> otherwise gnulib-tool's --create-testdir with the named modules will break.
>
> Can you please revisit this (i.e. test --create-testdir once without and once
> with my proposed correction)?
>
> Bruno
I didn't know how to test my patch without setting up a project
manually. Thank you for explaining me how to do that. I was able to
identify my mistake then.
Here is an updated patch with a rationale in the ChangeLog:
0001-gnulib-tool-don-t-automatically-distribute-files-fro.patch
Description: Text Data
Thanks for the review (to both of you).
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
- Not distributing README-release automatically., Mathieu Lirzin, 2017/03/05
- Re: Not distributing README-release automatically., Jim Meyering, 2017/03/07
- Re: Not distributing README-release automatically., Mathieu Lirzin, 2017/03/07
- Re: Not distributing README-release automatically., Jim Meyering, 2017/03/07
- Re: Not distributing README-release automatically., Mathieu Lirzin, 2017/03/07
- Re: Not distributing README-release automatically., Mathieu Lirzin, 2017/03/14
- Re: Not distributing README-release automatically., Jim Meyering, 2017/03/14
- Re: Not distributing README-release automatically., Bruno Haible, 2017/03/14
- Re: Not distributing README-release automatically., Jim Meyering, 2017/03/14
- Re: Not distributing README-release automatically.,
Mathieu Lirzin <=
- Re: Not distributing README-release automatically., Jim Meyering, 2017/03/14