Re: gnulib poll() returns POLLERR on Win32 platform, breaking libvirt

[Daniel P. Berrange]

On Wed, Apr 19, 2017 at 06:23:33PM +0200, Paolo Bonzini wrote:
> 
> 
> On 19/04/2017 17:50, Daniel P. Berrange wrote:
> >> But perhaps it's simpler to add "#undef recv" and "#undef select" near
> >> the top of the file, in addition to this change.
> > 
> > If we add the undef's then we don't need to change anything related to
> > windows_compute_revents_socket() as it'd be calling the native recv()
> > which expects the SOCKET rather than fd.
> > 
> > If we undef those functions, would that not re-introduce the bug mentioned
> > in http://lists.gnu.org/archive/html/bug-gnulib/2015-02/msg00139.html  ?
> 
> No, because that's itself a #define:
> 
> # define recv recv_used_without_including_sys_socket_h
> 
> that is introduced, for whatever reason I cannot fathom, by
> lib/sys_time.in.h.

Ok, it sounds like we only need the #undef to fix this all then

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|