[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore fi
From: |
Darshit Shah |
Subject: |
Re: [PATCH] gnulib-tool.py: Append, don't replace existing VCS ignore files |
Date: |
Wed, 13 Sep 2017 00:19:18 +0200 |
User-agent: |
NeoMutt/20170907-3-659cd2 (1.9.0) |
* Dmitry Selyutin <address@hidden> [170911 21:32]:
> Hi all,
>
> > As explained above, this patch helps converge gnulib-tool.py and
> > gnulib-tool. There is a behavioural difference which I also consider to
> > be a regression, and hence a string need to fix it.
> Thanks for the patch! Looks perfectly fine from my side. Could you push it
> into the repository, please?
>
> > But we are not there yet. Maybe in one or two weeks, but not now.
> I think it is a way too optimistic forecast. Anyway, I do my best, though my
> Python skills are a little bit rusty. :-)
>
> > Dmitry's work with the Python script has been great
> Well, I wouldn't say after looking into the code, but at least it is working
> somehow and can be a basic for a much better API. Remember that we're staying
> on giants' shoulders, I've just rewritten what was created before in another
> language. :-) Anyway, thank you for your kind words!
>
>
> --
> With best regards,
> Dmitry Selyutin
Bruno,
Could you please push this patch to master?
--
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
signature.asc
Description: PGP signature