[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] getloadavg: Allow building on Windows without Cygwin
|
From: |
Paul Smith |
|
Subject: |
Re: [PATCH] getloadavg: Allow building on Windows without Cygwin |
|
Date: |
Sun, 17 Jun 2018 18:14:53 -0400 |
On Sun, 2018-06-17 at 22:31 +0200, Bruno Haible wrote:
> > I thought in general we were avoiding use of the _WINxx
> > preprocessor defines, and instead preferring WINDOWS32.
>
> Maybe in general in GNU. But not in gnulib.
>
> > > But there is no implementation for native Windows!
> >
> > True, but it does compile, run, and return a non-error code. The
> > values are all 0 however. From getloadavg.c:
> >
> > # if !defined (LDAV_DONE) && (defined (__MSDOS__) || defined (WINDOWS32))
>
> This relies on the symbol WINDOWS32, which is not defined by gnulib.
No, but it is defined by GNU make's version of config.h on Windows :).
And getloadavg.c includes config.h.