Re: [PATCH] af_alg: avoid hangs when reading from streams

[Bruno Haible]

Pádraig Brady wrote:
> I'll push this in a while.

Thanks.

> diff --git a/lib/md5.c b/lib/md5.c
> index ea69a59..2b55cc6 100644
> --- a/lib/md5.c
> +++ b/lib/md5.c
> @@ -172,7 +172,9 @@ md5_stream (FILE *stream, void *resblock)
>          {
>            /* Either process a partial fread() from this loop,
>               or the fread() in afalg_stream may have gotten EOF.
> -             We need to avoid a subsequent fread() due to glibc BZ 1190.  */
> +             We need to avoid a subsequent fread() as EOF may
> +             not be sticky.  For details of such systems, see:
> +             https://sourceware.org/bugzilla/show_bug.cgi?id=1190  */
>            if (feof (stream))
>              goto process_partial_block;
> 

Also in the 3 other files. (There were 4 occurrences of this comment in total.)

Bruno