|
From: | Paul Eggert |
Subject: | Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789) |
Date: | Fri, 9 Nov 2018 18:53:21 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Bruno Haible wrote:
What do you mean? I don't see an 'mktime-tests' module, nor a 'timegm-tests' module, not a 'localtime-tests' module in gnulib. Gnulib has some tests whether the system's mktime() has certain bugs, but no verification that the replacement code actually fixes these bugs, nor any other unit test.
Ah, sorry, I thought there was a mktime-tests module. Anyway, there are mktime tests in glibc which is the "upstream" version. That being said, it'd be nice if someone added mktime tests for Gnulib too, as that would test Gnulib mktime on non-Glibc platforms and would also check the Gnulib packaging.
[Prev in Thread] | Current Thread | [Next in Thread] |