[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: di-set: Fix memory leak
|
From: |
Bernhard Voelker |
|
Subject: |
Re: di-set: Fix memory leak |
|
Date: |
Fri, 19 Apr 2019 00:06:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hi Bruno,
On 4/18/19 11:42 PM, Bruno Haible wrote:
> I would prefer to see the fix in lib/di-set.c, not lib/ino-map.c.
> Rationale: in 99% of the uses of the 'ino-map' module, the NULL
> check is not needed.
Fine by me. ;-)
BTW: the _GL_ATTRIBUTE_NONNULL decl of ino_map_free would have
made problems anyway ...
> The change to tests/test-di-set.c looks good. If you can commit
> that as well?
Sure, thanks - new patch attached - du(1) works again. ;-)
Have a nice day,
Berny
0001-di-set-allow-free-with-ino_map-being-NULL.patch
Description: Text Data