[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] copy-file-range: new module
From: |
Bruno Haible |
Subject: |
Re: [PATCH 1/2] copy-file-range: new module |
Date: |
Fri, 28 Jun 2019 21:30:24 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-151-generic; KDE/5.18.0; x86_64; ; ) |
Pádraig Brady wrote:
> https://sourceware.org/ml/libc-alpha/2019-06/msg00873.html
In the NEWS entry, Florian writes:
Applications which use the
copy_file_range function will have to be run on kernels which implement
the copy_file_range system call.
I find this misleading. Coreutils will want to continue to use copy_file_range
whenever the libc provides this function, and at the same time be able to run
on all Linux kernel versions.
Paul's argument convinced me:
> > ... a reliable use of copy_file_ranges will need
> > to be followed by a read+write loop that handles the special cases where
> > copy_file_ranges fails. And this read+write loop will work even if
> > copy_file_range is a stub that always fails. So there's no practical need
> > to
> > emulate copy_file_range [in glibc nor gnulib].
Maybe the NEWS entry could be changed to state something similar?
Bruno