Re: [PATCH] careadlinkat: fix GCC 10 workaround

[Bernhard Voelker]

On 2020-08-17 21:49, Paul Eggert wrote:
> Thanks, that's a good idea for GCC 10 since it lets the code allocate the 
> first 
> buffer on the stack too, even if warnings are enabled. However, I would 
> rather 
> have the code use __attribute__ ((__noinline__)) only if GCC_LINT is defined. 
> The point of GCC_LINT is to make it clear to readers how code is written a 
> particular way merely to pacify bogus compiler warnings. I'd rather do this 
> systematically, rather than use GCC_LINT in some places where the problem 
> occurs 
> and not use it in others. With that in mind, I installed the attached patch.

Thanks for the patch, but the situation is pretty much the same as before:
the warning only goes away with GCC_LINT.

The question seems to be if the performance degradation of not-inlining is 
larger
than switching from stack to malloc'ed storage.

Have a nice day,
Berny