[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Typo in quote.h
From: |
Bruno Haible |
Subject: |
Re: Typo in quote.h |
Date: |
Sun, 01 Nov 2020 22:12:26 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-193-generic; KDE/5.18.0; x86_64; ; ) |
I wrote:
> If you see "options" as a generalization of "style" and "custom", then
> the systematic name should be 'quotearg_n_options_mem'. But then the
> functions which return their result in a buffer or freshly allocated
> should better be named
>
> quotearg_options_buffer instead of quotearg_buffer
> quotearg_alloc_options instead of quotearg_alloc
> quotearg_alloc_options_mem instead of quotearg_alloc_mem
Correction: The naming scheme is
quotearg<return_convention><customizations><nul_handling>
where
<return_convention> is either '' (for slot 0) or
'_n' (for slot n) or '_buffer' or '_alloc',
<customizations> is either '' or '_style' or '_custom' or
'_options',
<nul_handling> is either '' or '_mem'.
The proposed renamings should therefore be
quotearg_buffer_options instead of quotearg_buffer
quotearg_alloc_options instead of quotearg_alloc
quotearg_alloc_options_mem instead of quotearg_alloc_mem
Bruno